docs: Canister settings guide#40
Conversation
Review: Canister settings guideMust fix
Suggestions
Verified
|
|
Please review before merging. |
|
Add a Please review before merging. |
|
Correction to my previous comment: The The |
6cb126b to
b15ab0d
Compare
b15ab0d to
d572741
Compare
|
Feedback addressed:
|
…m default
- snapshot_visibility: remove incorrect icp.yaml key and yaml example; add note
that icp-cli / icp.yaml support is not yet available, use management canister
- snapshot_visibility Motoko type: add missing #allowed_viewers : [Principal]
variant to match ic.did (which has three variants, not two)
- Rust CanisterSettings: remove snapshot_visibility field (does not exist in
ic-cdk's struct — compilation error if included)
- environment_variables Motoko type: fix ?[(Text, Text)] -> ?[{name : Text; value : Text}]
to match the management canister's Candid record type
- wasm_memory_limit default: 0 (no limit) -> 3_221_225_472 (3 GiB) per cdk-rs;
remove resolved verification comment
- Freezing threshold description: note that survival estimate includes memory
usage and subnet storage cost, not just execution rate
|
Review complete. All findings addressed in commit e5cdce7: Fixed:
Verified:
|
aaaaa-aa (management canister) and 2vxsx-fae (anonymous) as allowed_viewers are semantically equivalent to public — anyone can be the anonymous principal. Replace with placeholder principals that illustrate the actual use case: restricting log access to specific known principals like a monitoring service or auditor identity.
Summary
icp canister settings update), and programmatic updates via the management canister (Motoko and Rust)snapshot_visibility: Available via management canister calls; icp-cli/icp.yaml support not yet implemented (will be picked up on icp-cli bump)wasm_memory_limitdefault: 3 GiB (3,221,225,472 bytes) per cdk-rsSync recommendation
informed by dfinity/portal — docs/building-apps/canister-management/settings.mdx, docs/building-apps/canister-management/control.mdx, docs/references/_attachments/ic.did (snapshot_visibility field); dfinity/icp-cli — docs/reference/canister-settings.md, docs/reference/cli.md; dfinity/icskills — skills/cycles-management/SKILL.md