Skip to content

Conversation

@andrewbattat
Copy link
Contributor

@andrewbattat andrewbattat commented Dec 26, 2025

@andrewbattat andrewbattat self-assigned this Dec 26, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request modifies the IC-OS configuration types library (rs/ic_os/config_types/src/lib.rs).

Please ensure you have followed the Configuration Update Protocol guidelines——particularly if adding a new enum or enum variants:

Enum Variant Forward Compatibility Guidelines: If adding a new enum or new variants to an enum, ensure older versions can handle unknown variants gracefully by using #[serde(other)] on a fallback variant. See examples: GuestVMType::Unknown and Ipv6Config::Unknown.

To acknowledge this reminder and unblock the PR, dismiss this code review by:

  • Going to the bottom of the pull request page
  • Finding where this bot is requesting changes
  • Clicking the three dots on the right
  • Selecting "Dismiss review"

For complete guidelines, see the documentation at the top of rs/ic_os/config_types/src/lib.rs.

CONFIG_TYPES_COMPATIBILITY_REMINDER_DEDUP

@andrewbattat
Copy link
Contributor Author

andrewbattat commented Dec 29, 2025

I want to follow up on this with another reorganization, but this is enough for now!

@andrewbattat andrewbattat marked this pull request as ready for review December 31, 2025 00:07
@andrewbattat andrewbattat requested review from a team as code owners December 31, 2025 00:07
@github-actions github-actions bot added the @node label Dec 31, 2025
@andrewbattat andrewbattat enabled auto-merge January 8, 2026 02:17
@andrewbattat andrewbattat added this pull request to the merge queue Jan 8, 2026
Merged via the queue into master with commit 41691e2 Jan 8, 2026
93 of 95 checks passed
@andrewbattat andrewbattat deleted the andrew/better-organize-rs-icos branch January 8, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants