feat(rosetta-api): display DB index optimizations status #8196
+158
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
approved these changes
Dec 29, 2025
mbjorkqvist
reviewed
Jan 7, 2026
| ); | ||
| last_log = now; | ||
| } | ||
| true // continue |
Contributor
There was a problem hiding this comment.
Suggested change
| true // continue | |
| false // continue |
I believe this should be false to continue (true -> interrupt/abort). I tried first creating a database without indexes using the following:
bazel run //rs/rosetta-api/icp:ic-rosetta-api -- --store-location /tmp --environment production --expose-metrics --log-level DEBUG --canister-id xafvr-biaaa-aaaai-aql5q-cai --token-symbol TESTICP
Then I exited Rosetta and reran the above command with the additional flag --optimize-search-indexes, which caused Rosetta to exit with the following error:
thread 'main' panicked at rs/rosetta-api/icp/src/main.rs:395:35:
Failed to initialize ledger client: InternalError(false, Details { error_message: Some("Failed to initialize SQLite database: interrupted"), extra_fields: {} })
When changing the above true to false, the new functionality in this PR was running as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFI-1816: Print search index optimization status when starting up Rosetta