build(deps): bump golangci/golangci-lint-action from 9.2.0 to 9.2.1 in the gha group#11
Closed
dependabot[bot] wants to merge 5 commits into
Closed
build(deps): bump golangci/golangci-lint-action from 9.2.0 to 9.2.1 in the gha group#11dependabot[bot] wants to merge 5 commits into
dependabot[bot] wants to merge 5 commits into
Conversation
Walking up the directory tree to find a Taskfile/Makefile/mise.toml meant that running gogo inside an untrusted checkout (or a temp dir under one) could silently execute an ancestor's task file. Restrict the lookup to cwd only.
Any inherited env value starting with op:// flowed through to hasOpSecrets and forced the task to run under `op run`. An attacker who can set the parent process's environment could therefore trigger 1Password credential prompts for arbitrary tasks. Drop op:// values from os.Environ() when building the base env; legitimate op:// references must come from the task file (env, dotenv, or top-level secrets:).
writeChecksum used os.WriteFile, which follows symlinks. A local attacker who could create a symlink in .gogo/checksum/ before the user ran a task could redirect the write to an arbitrary file. Remove any pre-existing entry first (Remove does not follow symlinks) and then create the file with O_CREATE|O_EXCL so a racing symlink replacement fails the open.
Task names appear in on-disk checksum paths, terminal log lines and shell completion output. The previous validator only blocked path separators and '..', so a task file could still smuggle in control characters, terminal escapes, shell metacharacters or whitespace. Allow only ASCII letters, digits, '-', '_' and ':' (the namespace separator), and forbid leading/trailing/consecutive ':'.
Bumps the gha group with 1 update: [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action). Updates `golangci/golangci-lint-action` from 9.2.0 to 9.2.1 - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@1e7e51e...82606bf) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-version: 9.2.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gha ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
Author
|
Looks like golangci/golangci-lint-action is updatable in another way, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the gha group with 1 update: golangci/golangci-lint-action.
Updates
golangci/golangci-lint-actionfrom 9.2.0 to 9.2.1Release notes
Sourced from golangci/golangci-lint-action's releases.
Commits
82606bfchore: prepare release v9.2.197c8387chore: improve workflows (#1394)28d0a19build(deps): bump the dependencies group across 1 directory with 2 updates633fbc7build(deps): bump github/codeql-action from 4.35.3 to 4.35.4 (#1391)59f43e2build(deps): bump github/codeql-action from 4.35.2 to 4.35.3 (#1389)9eb174ebuild(deps): bump fast-xml-builder from 1.1.5 to 1.2.0 (#1386)4f52504build(deps): bump github/codeql-action from 4 to 4.35.2 (#1384)6f87dfddocs: update examplesc9500d7chore: improve workflows03b1faachore: improve issue templatesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions