Remove deprecated StreamingSession.activate()#1766
Open
dgreif wants to merge 2 commits into
Open
Conversation
The method was a thin wrapper around requestKeyFrame() with no remaining callers. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Waiting to merge this until the next major release |
Major bump since the deprecated public API method is removed. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: a5eacaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamingSession.activate()method, which was a thin wrapper aroundrequestKeyFrame()with no remaining callersWebrtcConnection.activate()is a separate private method (sendsactivate_sessionto keep streams alive) and was intentionally left unchangedStreamingSessionWrapper.activate()in homebridge-ring is unrelated and unchangedTest plan
npm run build -w ring-client-apinpm test -w ring-client-api(18 tests passed)Made with Cursor