Skip to content

chore: re-enable @typescript-eslint/no-unused-vars#1768

Merged
dgreif merged 3 commits into
mainfrom
chore/enable-eslint-no-unused-vars
Jun 12, 2026
Merged

chore: re-enable @typescript-eslint/no-unused-vars#1768
dgreif merged 3 commits into
mainfrom
chore/enable-eslint-no-unused-vars

Conversation

@dgreif

@dgreif dgreif commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Re-enables @typescript-eslint/no-unused-vars as an error in the shared ESLint config, with argsIgnorePattern: '^_' for intentionally unused function parameters.
  • Fixes 6 existing violations uncovered by the rule:
    • ring-client-api: replaced unused catch bindings with optional catch clauses in location.ts, refresh-token.ts, webrtc-connection.ts, and util.ts.
    • homebridge-ring: removed unused logError and generateMacAddress imports from ring-platform.ts.

Test plan

  • npm run lint passes across the monorepo

Made with Cursor

dgreif and others added 2 commits June 12, 2026 10:57
uuid v14 ships its own TypeScript definitions; @types/uuid is a deprecated npm stub.

Co-authored-by: Cursor <cursoragent@cursor.com>
Turn the rule back on with argsIgnorePattern '^_' and fix existing
violations by removing unused imports and using optional catch bindings.

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: be346ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dgreif dgreif merged commit 009181f into main Jun 12, 2026
8 checks passed
@dgreif dgreif deleted the chore/enable-eslint-no-unused-vars branch June 12, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant