Fixed OBJ import crashing on IEEE754 special values (nan/inf)#639
Open
Micheus wants to merge 1 commit into
Open
Fixed OBJ import crashing on IEEE754 special values (nan/inf)#639Micheus wants to merge 1 commit into
Micheus wants to merge 1 commit into
Conversation
It was reported at SourceForge that Wings3D was crashing when vertex coordinates were exported with nan/inf/1e999 values. I took a look at and I found we already a utility wings_util:string_to_float/1 that handle it partially. So, I added the 'inf' handle option and then I changed the e3d_obj and e3d_bzw to call it instead of use the list_to_float/1 directly. In order to set a inf/-inf value on import I used as reference the lower value I found in use in wings_face (1.0e-16). ref.: https://sourceforge.net/p/wings/bugs/252/ Note: Fixed the obj and bzw importers to handle nan/inf values. Thanks Dr. Mohammadreza Ashouri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was reported at SourceForge that Wings3D was crashing when vertex coordinates were exported with nan/inf/1e999 values.
I took a look at and I found we already a utility wings_util:string_to_float/1 that handle it partially. So, I added the 'inf' handle option and then I changed the e3d_obj and e3d_bzw to call it instead of use the list_to_float/1 directly.
In order to set a inf/-inf value on import I used as reference the lower value I found in use in wings_face (1.0e-16).
ref.: https://sourceforge.net/p/wings/bugs/252/
Note: Fixed the obj and bzw importers to handle nan/inf values. Thanks Dr. Mohammadreza Ashouri