fix: support min/max values validation #502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
🚀 Deployed on https://pr-502--dhis2-data-entry.netlify.app |
Contributor
Author
|
min/max validation doesn't seem to work smoothly on the new app after refreshing, i.e. the yellow background doesn't show on refresh, something we should investigate separately. It also doesn't seem to work on section forms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for min/max validation
fixes https://dhis2.atlassian.net/browse/DHIS2-20577
min-max-values.webm
ps: one limitation is that the warning doesn't show if a limit was added on field until the form is refreshed - this is, though, the same behavior as the old legacy app, and the new app.