fix: clear TimeOff entries in seed --clear#149
Merged
Conversation
TimeOff records created by seed_sample_data were never deleted on --clear. Add SEED_TIMEOFF_TITLES constant and delete matching rows in _clear(), same pattern as SEED_TODO_TITLES. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
seed_sample_data --clearleftTimeOffrecords behind. Every--clear+ reseed cycle accumulated more vacation/training entries.Fix
SEED_TIMEOFF_TITLESconstant (mirrors the titles in_create_time_off)_clear()now deletes matchingTimeOffrows and includes them in the "nothing to clear" guard and the summary message_create_*methods — everything else is covered (cascade from Client/Session/Invoice, or explicit deletes)Test plan
./dev.py lint)./dev.py manage seed_sample_data --clear --yesleaves noTimeOffrows behind🤖 Generated with Claude Code