fix: suppress pypdf EOF warnings in test output#155
Merged
Conversation
pypdf emits "EOF marker not found" via warnings.warn() for slightly malformed PDFs it can still parse. These leaked into test output as noise. Wrap the PdfReader calls in warnings.catch_warnings() since the existing try/except already handles actual read failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"EOF marker not found"viawarnings.warn()for slightly malformed PDFs it can still parsePdfReadercalls inwarnings.catch_warnings()/simplefilter("ignore")inside_read_page_rotationsand_restore_page_rotations— the surroundingtry/exceptalready handles actual read failures, so suppressing the warnings is safeTest plan
./dev.py testand confirm no "EOF marker not found" lines in output🤖 Generated with Claude Code