Freshness & merge collision fix.#31
Open
opencode-agent[bot] wants to merge 2 commits into
Open
Conversation
Co-authored-by: dianlight <dianlight@users.noreply.github.com>
|
User opencode-agent[bot] does not have write permissions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my analysis:
Q1: Why 16.x was identified as missing
The
check_releases.pyfreshness check (scripts/check_releases.py:186) marks any release as stale if itsupdated_at≤ the last commit date ofconfig/modules.json. Sincemodules.jsonwas modified on 2026-06-18 (PR #27 merge), all 16.x releases (published 2025-07/2025-11, withupdated_ataround 2026-03-22 for 16.3) were flagged as stale and needing rebuild. WithMAX_VERSIONS=1(line 42), only the newest stale version was selected.This is by-design behavior: when
modules.jsonchanges (e.g., a new module is added), prior releases must be rebuilt.Q2: Why the release errored
The "Create release 16.3" job (line 858) failed at "Aggregate build manifests" (line 920). Two problems:
build_manifest.jsonfilename collision: Every board's artifact contains abuild_manifest.json.download-artifact@v8withmerge-multiple: trueoverwrites duplicates, leaving only one board's manifest.xargs: The aggregation usedecho "${MANIFESTS}" | xargs python3 -c "..."which is brittle withset -euo pipefailand can fail silently on quoting/argument issues.Changes made
Three files modified to fix both issues:
scripts/check_releases.py:aggregate_manifests()function to safely merge per-board manifest filescheck/aggregate-manifests).github/workflows/main_build.yml:build_manifest_${BOARD}.json(unique per board, survivesmerge-multiple)build_manifest_*.jsonxargs+inline Python with a call tocheck_releases.py aggregate-manifestsdetect-versionscall to use thechecksubcommandCloses #30
opencode session | github run