Skip to content

Freshness & merge collision fix.#31

Open
opencode-agent[bot] wants to merge 2 commits into
mainfrom
opencode/issue30-20260623074944
Open

Freshness & merge collision fix.#31
opencode-agent[bot] wants to merge 2 commits into
mainfrom
opencode/issue30-20260623074944

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Here's my analysis:

Q1: Why 16.x was identified as missing

The check_releases.py freshness check (scripts/check_releases.py:186) marks any release as stale if its updated_at ≤ the last commit date of config/modules.json. Since modules.json was modified on 2026-06-18 (PR #27 merge), all 16.x releases (published 2025-07/2025-11, with updated_at around 2026-03-22 for 16.3) were flagged as stale and needing rebuild. With MAX_VERSIONS=1 (line 42), only the newest stale version was selected.

This is by-design behavior: when modules.json changes (e.g., a new module is added), prior releases must be rebuilt.

Q2: Why the release errored

The "Create release 16.3" job (line 858) failed at "Aggregate build manifests" (line 920). Two problems:

  1. build_manifest.json filename collision: Every board's artifact contains a build_manifest.json. download-artifact@v8 with merge-multiple: true overwrites duplicates, leaving only one board's manifest.
  2. Fragile inline Python via xargs: The aggregation used echo "${MANIFESTS}" | xargs python3 -c "..." which is brittle with set -euo pipefail and can fail silently on quoting/argument issues.

Changes made

Three files modified to fix both issues:

scripts/check_releases.py:

  • Added aggregate_manifests() function to safely merge per-board manifest files
  • Converted argument parser to sub-commands (check / aggregate-manifests)

.github/workflows/main_build.yml:

  • Changed manifest filename to build_manifest_${BOARD}.json (unique per board, survives merge-multiple)
  • Updated upload glob to build_manifest_*.json
  • Replaced fragile xargs+inline Python with a call to check_releases.py aggregate-manifests
  • Updated detect-versions call to use the check subcommand

Closes #30

New%20session%20-%202026-06-23T07%3A49%3A43.910Z
opencode session  |  github run

Co-authored-by: dianlight <dianlight@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

User opencode-agent[bot] does not have write permissions

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version Check and Actions errore

1 participant