BPMNAdapter: sanitize XML name attributes during import to preserve special-character labels#2379
Draft
BPMNAdapter: sanitize XML name attributes during import to preserve special-character labels#2379
name attributes during import to preserve special-character labels#2379Conversation
|
…butes Co-authored-by: CraneReturn <127602190+CraneReturn@users.noreply.github.com>
…port Co-authored-by: CraneReturn <127602190+CraneReturn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix BPMNAdapter special character reflection issue
BPMNAdapter: sanitize XML Mar 2, 2026
name attributes during import to preserve special-character labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BPMN shape labels containing raw special characters (
<,>,&) could break XML parsing inBPMNAdapter, causing names to fail to round-trip on import. This alignsbpmn-elements-adapterbehavior with the previously fixed adapter path by sanitizingnameattributes before parsing.Change: import-side sanitization in
bpmn-elements-adaptersanitizeNameAttributes(xml: string)inpackages/extension/src/bpmn-elements-adapter/index.ts.adapterXmlInwhen input is an XML string, beforelfXml2Json(...).name="..."attribute values are normalized; existing entities remain intact.Change: focused regression coverage
packages/extension/src/bpmn-elements-adapter/__tests__/adapter_in.test.jswith cases for:A < B & C)A & B < C)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.