Document date and datetime field types in README#44
Merged
Conversation
Fivell
force-pushed
the
refactor/dry-cleanup
branch
from
645f8ae to
69701e6
Compare
|
There was a problem hiding this comment.
Pull request overview
This PR documents the distinction between date-only and datetime field types in the SDK's README, and makes two code changes to align the resource model with the API: removing createdAt from EncryptedFile (not returned by the API) and changing CapacityPool.renewDate from LocalDate to String.
Changes:
- Added a "Date and Datetime Fields" section to README documenting which fields use
OffsetDateTime,LocalDate, orString - Removed unused
createdAtfield fromEncryptedFileresource - Changed
CapacityPool.renewDatetype fromLocalDatetoString
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | New documentation section explaining date/datetime field type conventions |
| src/main/java/com/didww/sdk/resource/EncryptedFile.java | Removed createdAt field not returned by the API |
| src/main/java/com/didww/sdk/resource/CapacityPool.java | Changed renewDate from LocalDate to String, removed unused import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.