Conversation
|
There was a problem hiding this comment.
Pull request overview
Adds a new Java example demonstrating how to order a DID by NANPA NPA/NXX prefix, while also updating several existing examples to align with the current SDK resource construction patterns (removing now-nonexistent *.build(id) usage) so the examples compile cleanly.
Changes:
- Added
OrdersNanpaExampleto demonstrate ordering by NANPA prefix viananpa_prefix_id. - Updated multiple examples to use SDK resources directly (and
withId(...)where applicable) instead of removedbuild(...)helpers. - Documented the new example in
examples/README.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/src/main/java/com/didww/examples/VoiceInTrunkGroupsExample.java | Updates trunk-group relationship assignment to use the created trunk objects directly. |
| examples/src/main/java/com/didww/examples/OrdersNanpaExample.java | New example: look up a NANPA prefix and place a DID order using the resolved SKU + nanpa_prefix_id. |
| examples/src/main/java/com/didww/examples/IdentityAddressProofsExample.java | Replaces removed build(...) helpers with direct resources / withId(...) for proof file relationships. |
| examples/src/main/java/com/didww/examples/DidTrunkAssignmentExample.java | Uses new <Resource>().withId(...) for patch/update payloads and relationships. |
| examples/src/main/java/com/didww/examples/BalanceExample.java | Fixes type mismatch by formatting BigDecimal balances directly. |
| examples/README.md | Adds an entry for OrdersNanpaExample. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
OrdersNanpaExampleshowing how to order a DID number by NPA/NXX prefixBalanceExample,VoiceInTrunkGroupsExample,DidTrunkAssignmentExample,IdentityAddressProofsExample)examples/README.mdwith new example entryTest plan
DIDWW_API_KEY=... ./gradlew runExample -PexampleClass=com.didww.examples.OrdersNanpaExampleagainst sandbox