fix(i18n): add missing dashboard keys and fix EN fallbacks#2500
fix(i18n): add missing dashboard keys and fix EN fallbacks#2500Gi99lin wants to merge 2 commits into
Conversation
Provider Quota showed Portuguese labels when EN was selected because keys were missing from en.json and fallbacks were PT-only. Add usage, combos, settings, and providers keys across locales, wire components to t(), and extend provider-limits UI tests. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Code Review
This pull request externalizes hardcoded strings into translation keys across several dashboard components, including the cache, costs, providers, and usage pages. It also populates internationalization files with missing keys and adds unit tests to ensure these keys are defined in the English locale. Feedback highlights a few remaining hardcoded strings in the Caveman context page description and the 'Fast' tier label in provider cards that should be localized for consistency.
| <p className="mt-1 text-xs text-text-muted"> | ||
| Rewrite chat history with shorter wording. Reduces input tokens by ~50%. | ||
| </p> |
There was a problem hiding this comment.
The description text for the "Input compression" section is still hardcoded in English. Since this PR aims to wire dashboard components to translation keys, this paragraph should also be externalized to the i18n messages.
| <p className="mt-1 text-xs text-text-muted"> | |
| Rewrite chat history with shorter wording. Reduces input tokens by ~50%. | |
| </p> | |
| <p className="mt-1 text-xs text-text-muted"> | |
| {t("inputCompressionDesc")} | |
| </p> |
| title={t("codexFastTierActiveChip")} | ||
| > | ||
| <span className="material-symbols-outlined text-[10px] leading-none">bolt</span> | ||
| Fast |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
Files Reviewed (7 files)
All 41 non-English locale files receive the same keys with The component changes correctly use Reviewed by qwen3.6-plus · 727,505 tokens |
Address PR review: externalize input compression description and provider Fast tier chip text via contextCaveman and providers keys. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
Summary
en.jsonand component fallbacks were PT-only.usage,combos,settings,providers,cache,costs, andcontextCavemankeys toen.jsonand sync to all 41 locales viai18n:sync-ui.t()instead of hardcoded strings (Provider Limits, Provider card, Cache, Costs, Caveman).en.json.Test plan
node --import tsx --test tests/unit/provider-limits-ui.test.ts