Skip to content

fix: Export correct MapInfoResponse type#34

Merged
gmaclennan merged 1 commit intomainfrom
fix/map-info-type
Mar 5, 2026
Merged

fix: Export correct MapInfoResponse type#34
gmaclennan merged 1 commit intomainfrom
fix/map-info-type

Conversation

@gmaclennan
Copy link
Member

The exported MapInfo type is not the same type as the /:mapId/info response type. Currently MapInfo is an internal type, and the response type is backwards compatible with the previous map server from @comapeo/core. This PR adds a new type export MapInfoResponse, deprecates the MapInfo type (to avoid a breaking change). Also adds a test that validates the response type on the /:mapId/info route.

@gmaclennan gmaclennan self-assigned this Mar 5, 2026
@gmaclennan gmaclennan requested a review from achou11 March 5, 2026 17:04
@gmaclennan gmaclennan merged commit bd4b5b6 into main Mar 5, 2026
12 checks passed
@gmaclennan gmaclennan deleted the fix/map-info-type branch March 5, 2026 17:58
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (ae7bc34) to head (ca433ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@    Coverage Diff     @@
##   main   #34   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants