feat: add MAP_SHARE_CANCELED error for declining canceled shares#39
Merged
gmaclennan merged 2 commits intomainfrom Mar 25, 2026
Merged
feat: add MAP_SHARE_CANCELED error for declining canceled shares#39gmaclennan merged 2 commits intomainfrom
gmaclennan merged 2 commits intomainfrom
Conversation
When a receiver tries to decline a share that the sender already canceled, return a specific MAP_SHARE_CANCELED (409) error instead of the generic DECLINE_SHARE_NOT_PENDING, so the client can distinguish cancellation from other non-pending states.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a receiver tries to decline a share that the sender already canceled, return a specific MAP_SHARE_CANCELED (409) error instead of the generic DECLINE_SHARE_NOT_PENDING, so the client can distinguish cancellation from other non-pending states.