test: add download, style-downloader, and tile-downloader tests; fix error propagation#98
Merged
gmaclennan merged 7 commits intomainfrom Mar 20, 2026
Merged
Conversation
Add comprehensive test coverage for the download pipeline: - test/download.js: end-to-end download tests with tile/glyph/sprite verification - test/style-downloader.js: StyleDownloader unit tests (constructor, getStyle, getSprites, getGlyphs, getTiles) - test/tile-downloader.js: tileIterator algorithm tests and downloadTiles functional tests - test/utils/smp-server.js: shared test utility for SMP HTTP server Also includes minor fixes: - download.js: handle error when Writer init fails before style download completes - Type annotations: use Readonly<BBox> for bbox parameters across download pipeline Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 20, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download(),StyleDownloader, anddownloadTiles/tileIterator(38 new tests)download()whengetStyle()fails — errors from unreachable URLs were becoming unhandled rejections instead of propagating through the returned streamReadonly<BBox>type annotations to accept readonly bbox tuples in public APIsstartSMPServer()test utility for serving SMP fixtures over HTTPTest plan
npx vitest run --project node)