WhoopProtocol test: break up gravity-magnitude expression for the type-checker#12
Merged
Merged
Conversation
…e-checker
The single-line nested-optional-coalescing form (gx ?? 0) * (gx ?? 0) + ...
occasionally blew the Swift type-checker's time budget in CI ("unable to
type-check this expression in reasonable time"), failing the WhoopProtocol
test job on unrelated PRs. A compiler perf cliff, not a real ambiguity;
naming the intermediate values fixes it without changing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Packages/**(currently failing on Sleep: show the duration trend as a bar chart (#85) #7).DecoderOracleTests.swift:86's single-line nested-optional-coalescing gravity-magnitude expression blows the Swift type-checker's time budget in CI ("the compiler is unable to type-check this expression in reasonable time") — a compiler perf cliff, not a real ambiguity. Breaking it into named, explicitly-typed sub-expressions fixes it without changing behavior.Test plan
swift testinPackages/WhoopProtocol: all 241 tests pass; the previously-timing-out file now compiles in ~1.4s.test (WhoopProtocol)pass).🤖 Generated with Claude Code