Localize missing Appearance settings strings#5
Closed
digitalerdude wants to merge 2 commits into
Closed
Conversation
…ency) These four strings were added to SettingsView.swift's appearanceCard but never made it into the string catalog, so every locale fell back to the English source text. Adds de/es/fr/it/pt-PT/zh-Hans/zh-Hant translations. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fitnessReadyLead() returns an already-localized String (via String(localized:)), but ReadinessChecklistCard.lead was typed LocalizedStringKey?, which SwiftUI treats as a lookup key rather than literal text. Retype to String? — Text(_:) accepts both, and this is the correct type for pre-resolved copy. Pre-existing break from commit 75a096a (PR ryanbr#81), unrelated to this branch's localization change; fixing here so PR #5's CI build passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
Author
|
Superseded by ryanbr#152 against upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Four strings under Settings → Appearance ("Sky behind cards" and its
caption, "Card transparency" and its caption) were added to
SettingsView.swift'sappearanceCardbut never made it intoStrand/Resources/Localizable.xcstrings, so every non-English locale fellback to the raw English source text instead of showing a translation.
Adds
de,es,fr,it,pt-PT,zh-Hans, andzh-Hantentries forall four strings, reusing existing catalog terminology (e.g. "Frecuencia
cardíaca"/"心率" for Heart Rate, "Fondo según el ciclo del día" for the
day-cycle background) so they read consistently with neighboring rows.
Note: pt-PT entries in this catalog are marked
needs_reviewthroughout(existing entries mix in Spanish words), and the four new ones follow that
same convention — worth a native pt-PT pass over the whole file at some
point.
Type of change
(Closest fit is "Documentation" — this is a string-catalog-only content
change, no code paths touched.)
How it was tested
Data-only change to
Localizable.xcstrings. Verified the file is validJSON and that all four keys now carry complete localization sets via a
Python script; no Swift/Kotlin code was touched so no build or test suite
applies.
Checklist
swift testinPackages/<name>) — N/A, no package touchedandroid/— N/A, not touchedStrandDesigntokens — no hardcoded colors, fonts, or spacing — N/A, no UI code changeddocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
None