Widget: republish on live heart-rate changes too (#114)#8
Closed
digitalerdude wants to merge 2 commits into
Closed
Widget: republish on live heart-rate changes too (#114)#8digitalerdude wants to merge 2 commits into
digitalerdude wants to merge 2 commits into
Conversation
A same-day maintainer fix (134197f) republished the Home/Lock-Screen widget snapshot on live battery/connection changes, since those are LIVE state (model.live) that never bumps the repo-cache refreshSeq the widget otherwise rides. WidgetSnapshot.bpm reads the same category of live field (model.bpm) but had no matching hook, so the widget's heart rate could freeze at a stale value for an entire foreground session while a strap was actively streaming. Adds the same foreground-gated republish hook for model.$bpm, mirroring the battery/connected ones already in place.
5 tasks
Owner
Author
|
Closing this fork-internal PR to declutter — the real submission lives at ryanbr/noop (upstream). See that repo's PR list for the current, actionable version of this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.live) that never bumps the repo-cacherefreshSeqthe widget's other fields ride. That commit explicitly scoped out other polish from Data inaccuracy on the iOS widget ryanbr/noop#114 but left one gap of the same kind:WidgetSnapshot.bpmreadsmodel.bpm(the smoothed live heart rate), which had no matching republish hook.model.$bpm-driven republish hook, foreground-gated exactly like the existing battery/connected ones.model.bpmalready change-guards itself iningestHR()(only assigns when the smoothed median actually moves), so this can't out-pace the existing hooks' throttling story.Test plan
NOOPiOS) target builds clean viaxcodebuild.🤖 Generated with Claude Code