ci: Use a regular cargo to build no-std targets.#231
ci: Use a regular cargo to build no-std targets.#231ThierryBerger merged 1 commit intodimforge:masterfrom
cargo to build no-std targets.#231Conversation
|
This will conflict with #227, but I'm happy to fix up any merge conflicts after whichever lands first. |
d373427 to
0cee0d3
Compare
`xargo` is no longer needed and has been in maintenance mode for over 7 years. This can run on `stable` rather than requiring `nightly` The build doesn't need `rustfmt`, so don't require that it be installed.
0cee0d3 to
fd785c4
Compare
ThierryBerger
left a comment
There was a problem hiding this comment.
I'm approving, but I have a minor concern over dropping nightly compilation: that means we don't have any ci testing nightly.
It's most definitely correct for this PR, but should we add a periodic CI step on master to test against nightly ? @sebcrozet
|
Thank you for this PR @waywardmonkeys ! Back in the days,
@Vrixyz We should keep a nightly test (on PRs) that checkes the simd-nightly feature. (But, yes, this should be in a separate PR.) |
Yes. Using This is what we do in |
|
As an aside, this would be a great time to bring up the work started in PR #170 and see about finding a victim to do more of that. :) |
|
Is this related to the failure I'm seeing in #249 ? 👀 |
sebcrozet
left a comment
There was a problem hiding this comment.
Thank you for checking @waywardmonkeys! Looks good.
xargois no longer needed and has been in maintenance mode for over 7 years.This can run on
stablerather than requiringnightlyThe build doesn't need
rustfmt, so don't require that it be installed.