Fix infinite loop in intersection_with_local_plane#295
Open
nikita240 wants to merge 1 commit intodimforge:masterfrom
Open
Fix infinite loop in intersection_with_local_plane#295nikita240 wants to merge 1 commit intodimforge:masterfrom
nikita240 wants to merge 1 commit intodimforge:masterfrom
Conversation
ThierryBerger
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test case
trimesh_plane_square_intersection. If you run this test with the current master, it will get stuck in an infinite loop. We're missing an exit condition.