Fix NaN originating from collinear triangles point projection.#358
Open
ThierryBerger wants to merge 4 commits intodimforge:masterfrom
Open
Fix NaN originating from collinear triangles point projection.#358ThierryBerger wants to merge 4 commits intodimforge:masterfrom
ThierryBerger wants to merge 4 commits intodimforge:masterfrom
Conversation
Contributor
ThierryBerger
commented
Jul 4, 2025
ThierryBerger
commented
- Improves Matrix index out of bounds. #310
… collinear triangles
ThierryBerger
changed the title
ThierryBerger
commented
Jul 17, 2025
Comment on lines
+223
to
+227
| // TODO: this can probably be optimized using data we already have ? | ||
| let length_sq_ab = ab.magnitude_squared(); | ||
| let length_sq_ac = ac.magnitude_squared(); | ||
| let length_sq_bc = bc.magnitude_squared(); |
Contributor
Author
There was a problem hiding this comment.
I'm out of my depth to find the correct data to operate on, but as it's quite the edge case I'd advocate to merge as-is and consider improving it in another PR.
ThierryBerger
commented
Jul 17, 2025
| }, | ||
| ); | ||
| } | ||
| } else if DIM != 2 { |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why this isn't a cfg directive ?
ThierryBerger
force-pushed
the
310-fix_flat_triangles
branch
2 times, most recently
from
bcaad6e to
11853b1
Compare
ThierryBerger
force-pushed
the
310-fix_flat_triangles
branch
from
11853b1 to
d956e74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.