Open
Conversation
ThierryBerger
force-pushed
the
ci
branch
9 times, most recently
from
3cb648a to
033ef1b
Compare
ThierryBerger
force-pushed
the
ci
branch
7 times, most recently
from
2249cd3 to
432683e
Compare
ThierryBerger
commented
Oct 29, 2025
.github/workflows/ci.yaml
Outdated
Comment on lines
37
to
39
| outputs: | ||
| slang-dir: ${{ steps.setup.outputs.slang-dir }} # Pass SLANG_DIR to dependent jobs | ||
| slang-cache-key: ${{ steps.setup.outputs.slang-cache-key }} # Pass SLANG_DIR to dependent jobs |
Author
There was a problem hiding this comment.
using outputs is the wrong approach if we want to support matrices, as the output is overwritten for each matrix (see https://github.com/orgs/community/discussions/17245 for more in depth discussion).
different approaches:
- preferred: we're not actually relying on a matrix here, as we only want to download slang, so drop the matrix, and download everything needed in 1 job.
- OR have a different job (name) for each target, so we can use output (great to support compiling slang from CI)
- OR do everything in the same job (not great for parallelization, but it's probably fine, and may end up saving total aggregated time.
Author
There was a problem hiding this comment.
I used a matrix to download slang, and another to test it.
Closed
… changing slang dir name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add script to download slang + make ci use it to compile and run tests.
This PR still uses dynamic linking ; static linking requires to download source from slang and compile it, (hence requiring all dev dependencies of slang, so it's a bit more involved)