Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @diptavo,
I have noticed that missing genotype data results in an error in a basic MultiSKAT model.
Created on 2019-06-11 by the reprex package (v0.2.1)
Bug fix
I found that the error message stems from the
MAFfunction stored inR/helpers.R. More specifically,MAFcontains asumfunction that will yield in NA, if the G matrix contains any NAs.I have added an
na.rm = TRUEto the sum function.I have also added a unit test that will fail with the version you currently have on the master, but pass with my version.
I let you choose what kind of files you want to merge into your master.