This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Add compatibility with the Glimmer Post Stream#247
Merged
Conversation
Refactored ad plugin initialization to use API enhancements and split logic into smaller functions for better organization. Updated compatibility to include a new version restriction.
cvx
approved these changes
Jul 7, 2025
| import { withPluginApi } from "discourse/lib/plugin-api"; | ||
| import Site from "discourse/models/site"; | ||
| import { registerWidgetShim } from "discourse/widgets/render-glimmer"; | ||
| import { withSilencedDeprecations } from "discourse/lib/deprecated"; |
Contributor
There was a problem hiding this comment.
looks like imports need an eslint autofix
Reordered imports for clarity and removed outdated plugin API version constraints to streamline initialization logic.
Updated the compatibility hash for `3.5.0.beta8-dev` in the discourse-adplugin compatibility file.
Updated AdSense, DFP Ads, and House Ads tests to run for both "enabled" and "disabled" glimmer_post_stream_mode. Updated templates and widgets to replace `widget-connector` with `ad-connector` for improved consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the ad plugin to support the Glimmer Post Stream and refactors ad rendering logic for improved compatibility and maintainability.
Key changes: