ClinVar ClinSig updates and resolving submissions ties (4/N)#285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What feature is being added or bug is being addressed?
Separate PR since there are a lot of edits to
scripts/resolve-clinvar-submissions.RUpdated the README since it was out of date.
What was your approach?
What GitHub issue does your pull request address?
Closes #283
Closes #282
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Download ClinVar files (I don't feel like this needs to be a data release?)
If you want to verify files:
Run resolve clinvar using the cancer concept IDs (file from January is fine, concept IDs don't update often).
Which areas should receive a particularly close look?
The output of the
scripts/resolve-clinvar-intepretations.Rand md5sum:Is there anything that you want to discuss further?
Documentation Checklist