Skip to content

Redesign docs change home page#7

Open
AndreiZiatiev wants to merge 4 commits intodjai-app:mainfrom
AndreiZiatiev:Redesign-docs--Change-Home-Page
Open

Redesign docs change home page#7
AndreiZiatiev wants to merge 4 commits intodjai-app:mainfrom
AndreiZiatiev:Redesign-docs--Change-Home-Page

Conversation

@AndreiZiatiev
Copy link
Copy Markdown

Redesign docs change home page

Comment thread _pages/index.html Outdated
<div class="col-sm-6 col-md-6 contrib-block">
<a href="{{ site.baseurl }}/studio/"><img src="{{ site.baseurl }}images/subprojects/apicurio_studio_logo_default_h50px.png" alt="Apicurio Studio subproject image"></a>
<h2><a href="{{ site.baseurl }}/studio/">Apicurio Studio</a></h2>
<a href="{{ site.baseurl }}/studio/"><img src="{{ site.baseurl }}images/dj-std.png" class="contrib-block-image" alt="Apicurio Studio subproject image"></a>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreiZiatiev what is the reason for adding the class contrib-block-image here? Why it worked before without the class?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreiZiatiev please also change the alt value to follow the DJAI project, the message should be DJAI subproject image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreiZiatiev please also change the alt value to follow the DJAI project, the message should be DJAI subproject image

Comment thread _pages/index.html Outdated
<div class="col-sm-6 col-md-6 contrib-block">
<a href="{{ site.baseurl }}/datamodels/"><img src="{{ site.baseurl }}images/subprojects/apicurio_datamodels_logo_default_h50px.png" alt="Apicurio Data Models subproject image"></a>
<h2><a href="{{ site.baseurl }}/datamodels/">Apicurio Data Models</a></h2>
<a href="{{ site.baseurl }}/datamodels/"><img src="{{ site.baseurl }}images/dj-dt-mdl.png" class="contrib-block-image" alt="Apicurio Data Models subproject image"></a>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreiZiatiev please change alt to follow the DJAI

Comment thread _pages/index.html
<p>Data modeling library for OpenAPI and AsyncAPI specifications</p>
</div>
<div class="col-sm-6 col-md-6 contrib-block">
<div class="col-sm-6 col-md-6 contrib-block-1">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreiZiatiev please remove this code block instead of hiding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants