Replace unmaintained unidecode with deunicode#39
Open
Vogeltak wants to merge 1 commit intodjudd:masterfrom
Open
Replace unmaintained unidecode with deunicode#39Vogeltak wants to merge 1 commit intodjudd:masterfrom
Vogeltak wants to merge 1 commit intodjudd:masterfrom
Conversation
Owner
|
Haven't had time to look at this yet - I'm afraid replacing unidecode doesn't seem super urgent to me since despite being unmaintained it also seems kinda "done" - but wanted to note that I did see this and will investigate more at some point. Appreciate the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unidecodecrate appears to be unmaintained. For similar reasons as in #38, we can replace this dependency with thedeunicodecrate that explicitly positions itself as an alternative.This currently breaks the
emojistest insrc/lib.rs. I couldn't quickly figure out how to best fix this. Thought that you might have some insights here?