fix(cli): clear connection timeout timer to prevent 5s exit delay#9
Merged
Conversation
…eval - Introduced a new section on extraction strategy emphasizing text-based extraction over screenshots. - Provided detailed steps on when to use `gettext` or `gethtml` and when to fall back to `screenshot` for better efficiency and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage: bridge [args]
Commands:
up Start ws-server and local-proxy
down Stop both services
restart down then up
status Show service state
logs [name] Tail logs (ws-server | local-proxy)
update [version] Upgrade to a release (default: latest)
doctor Diagnose the install
uninstall Remove ~/.browser-bridge/ (use --yes to skip prompt)
version Print installed + latest version
Browser commands (when services are running and a browser is connected):
browser:list List connected browsers
navigate Open a URL in the current tab
click Click an element
type Type text into an element
screenshot Take a screenshot
See 'bridge --help' for the full list. CLI commands that open a WebSocket connection were hanging for ~5 seconds after printing output. The connection-timeout +setTimeout+ was never cleared once the socket reached the OPEN state, so Bun kept the process alive until the timer expired.
Changes
Verification
Test Plan