Skip to content

#78 - Clean up NER types #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reckart merged 2 commits into from
Jun 14, 2026
Merged

#78 - Clean up NER types #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4654ec8
#78 - Clean up NER types
reckart Jun 14, 2026
48f814a
#78 - Clean up NER types
reckart Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .githooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ printf '%s\n' "$MODULES" | tr ',' '\n' | sed 's/^/ - /'
REPO_ROOT=$(git rev-parse --show-toplevel)
cd "$REPO_ROOT"

if ! mvn -q -pl "$MODULES" -Pspotless,checkstyle spotless:check checkstyle:check; then
if ! mvn -q -pl "$MODULES" -Pspotless,checkstyle,experimental spotless:check checkstyle:check; then
cat >&2 <<'EOF'

[pre-commit] Verification failed.
Expand Down
150 changes: 0 additions & 150 deletions dkpro-core-api-ner-asl/src/main/resources/desc/type/NamedEntity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,155 +22,5 @@
</featureDescription>
</features>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Person</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.PerDesc</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Norp</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Organization</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.OrgDesc</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Gpe</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.GpeDesc</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Location</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Product</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.ProductDesc</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Date</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Time</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Percent</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Money</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Quantity</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Ordinal</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Cardinal</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Event</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Plant</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Animal</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Substance</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Disease</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.WorkOfArt</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Law</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Language</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.ContactInfo</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Game</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Fac</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.FacDesc</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
<typeDescription>
<name>de.tudarmstadt.ukp.dkpro.core.api.ner.type.Nationality</name>
<description/>
<supertypeName>de.tudarmstadt.ukp.dkpro.core.api.ner.type.NamedEntity</supertypeName>
</typeDescription>
</types>
</typeSystemDescription>
9 changes: 0 additions & 9 deletions ...e-corenlp-gpl/src/main/resources/org/dkpro/core/corenlp/lib/ner-de-dewac_175m_600.crf.map
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions ...pl/src/main/resources/org/dkpro/core/corenlp/lib/ner-de-germeval2014.hgc_175m_600.crf.map
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions ...ore-corenlp-gpl/src/main/resources/org/dkpro/core/corenlp/lib/ner-de-hgc_175m_600.crf.map
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions .../src/main/resources/org/dkpro/core/corenlp/lib/ner-en-all.3class.caseless.distsim.crf.map
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions ...renlp-gpl/src/main/resources/org/dkpro/core/corenlp/lib/ner-en-all.3class.distsim.crf.map
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions ...rc/main/resources/org/dkpro/core/corenlp/lib/ner-en-conll.4class.caseless.distsim.crf.map
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions ...nlp-gpl/src/main/resources/org/dkpro/core/corenlp/lib/ner-en-conll.4class.distsim.crf.map
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions .../src/main/resources/org/dkpro/core/corenlp/lib/ner-en-muc.7class.caseless.distsim.crf.map
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions ...renlp-gpl/src/main/resources/org/dkpro/core/corenlp/lib/ner-en-muc.7class.distsim.crf.map
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions ...c/main/resources/org/dkpro/core/corenlp/lib/ner-en-nowiki.3class.caseless.distsim.crf.map
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions ...enlp-gpl/src/main/resources/org/dkpro/core/corenlp/lib/ner-es-ancora.distsim.s512.crf.map
View file
Open in desktop

This file was deleted.

42 changes: 21 additions & 21 deletions ...re-corenlp-gpl/src/test/java/org/dkpro/core/corenlp/CoreNlpNamedEntityRecognizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ public void testEnglish() throws Exception

JCas jcas = runTest("en", null, "IBM where John works is in Germany .");

String[] ne = { "[ 0, 3]Organization(ORGANIZATION) (IBM)",
"[ 10, 14]Person(PERSON) (John)", "[ 27, 34]Location(LOCATION) (Germany)" };
String[] ne = { "[ 0, 3]NamedEntity(ORGANIZATION) (IBM)",
"[ 10, 14]NamedEntity(PERSON) (John)", "[ 27, 34]NamedEntity(LOCATION) (Germany)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -56,8 +56,8 @@ public void test3classCaselessEnglish() throws Exception
JCas jcas = runTest("en", "all.3class.caseless.distsim.crf",
"ibm where john works is in germany .");

String[] ne = { "[ 0, 3]Organization(ORGANIZATION) (ibm)",
"[ 10, 14]Person(PERSON) (john)", "[ 27, 34]Location(LOCATION) (germany)" };
String[] ne = { "[ 0, 3]NamedEntity(ORGANIZATION) (ibm)",
"[ 10, 14]NamedEntity(PERSON) (john)", "[ 27, 34]NamedEntity(LOCATION) (germany)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -70,8 +70,8 @@ public void testNoWiki3classCaselessEnglish() throws Exception
JCas jcas = runTest("en", "nowiki.3class.caseless.distsim.crf",
"ibm where john works is in germany .");

String[] ne = { "[ 0, 3]Organization(ORGANIZATION) (ibm)",
"[ 10, 14]Person(PERSON) (john)", "[ 27, 34]Location(LOCATION) (germany)" };
String[] ne = { "[ 0, 3]NamedEntity(ORGANIZATION) (ibm)",
"[ 10, 14]NamedEntity(PERSON) (john)", "[ 27, 34]NamedEntity(LOCATION) (germany)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -84,8 +84,8 @@ public void test4classEnglish() throws Exception
JCas jcas = runTest("en", "conll.4class.distsim.crf",
"IBM where John works is in Germany .");

String[] ne = { "[ 0, 3]Organization(ORGANIZATION) (IBM)",
"[ 10, 14]Person(PERSON) (John)", "[ 27, 34]Location(LOCATION) (Germany)" };
String[] ne = { "[ 0, 3]NamedEntity(ORGANIZATION) (IBM)",
"[ 10, 14]NamedEntity(PERSON) (John)", "[ 27, 34]NamedEntity(LOCATION) (Germany)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -98,8 +98,8 @@ public void test4classCaselessEnglish() throws Exception
JCas jcas = runTest("en", "conll.4class.caseless.distsim.crf",
"ibm where john works is in germany .");

String[] ne = { "[ 0, 3]Organization(ORGANIZATION) (ibm)",
"[ 10, 14]Person(PERSON) (john)", "[ 27, 34]Location(LOCATION) (germany)" };
String[] ne = { "[ 0, 3]NamedEntity(ORGANIZATION) (ibm)",
"[ 10, 14]NamedEntity(PERSON) (john)", "[ 27, 34]NamedEntity(LOCATION) (germany)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -112,8 +112,8 @@ public void test4classCaselessMixedEnglish() throws Exception
JCas jcas = runTest("en", "conll.4class.caseless.distsim.crf",
"IBM where john works is in Germany .");

String[] ne = { "[ 0, 3]Organization(ORGANIZATION) (IBM)",
"[ 10, 14]Person(PERSON) (john)", "[ 27, 34]Location(LOCATION) (Germany)" };
String[] ne = { "[ 0, 3]NamedEntity(ORGANIZATION) (IBM)",
"[ 10, 14]NamedEntity(PERSON) (john)", "[ 27, 34]NamedEntity(LOCATION) (Germany)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -125,8 +125,8 @@ public void test7classEnglish() throws Exception

JCas jcas = runTest("en", "muc.7class.distsim.crf", "IBM where John works is in Germany .");

String[] ne = { "[ 0, 3]Organization(ORGANIZATION) (IBM)",
"[ 10, 14]Person(PERSON) (John)", "[ 27, 34]Location(LOCATION) (Germany)" };
String[] ne = { "[ 0, 3]NamedEntity(ORGANIZATION) (IBM)",
"[ 10, 14]NamedEntity(PERSON) (John)", "[ 27, 34]NamedEntity(LOCATION) (Germany)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -138,9 +138,9 @@ public void testGerman() throws Exception

JCas jcas = runTest("de", null, "Markus arbeitet seit 10 Jahren bei SAP in Deutschland .");

String[] ne = { "[ 0, 6]Person(PERSON) (Markus)",
"[ 35, 38]Organization(ORGANIZATION) (SAP)",
"[ 42, 53]Location(LOCATION) (Deutschland)" };
String[] ne = { "[ 0, 6]NamedEntity(PERSON) (Markus)",
"[ 35, 38]NamedEntity(ORGANIZATION) (SAP)",
"[ 42, 53]NamedEntity(LOCATION) (Deutschland)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -153,8 +153,8 @@ public void testHgcGerman() throws Exception
JCas jcas = runTest("de", "hgc_175m_600.crf",
"Markus arbeitet seit 10 Jahren bei SAP in Deutschland .");

String[] ne = { "[ 0, 6]Person(I-PER) (Markus)", "[ 35, 38]Organization(I-ORG) (SAP)",
"[ 42, 53]Location(I-LOC) (Deutschland)" };
String[] ne = { "[ 0, 6]NamedEntity(I-PER) (Markus)", "[ 35, 38]NamedEntity(I-ORG) (SAP)",
"[ 42, 53]NamedEntity(I-LOC) (Deutschland)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand All @@ -166,8 +166,8 @@ public void testSpanish() throws Exception

JCas jcas = runTest("es", null, "Hace 10 años Markus trabaja en SAP en Alemania .");

String[] ne = { "[ 13, 19]Person(PERS) (Markus)", "[ 31, 34]Organization(ORG) (SAP)",
"[ 38, 46]Location(LUG) (Alemania)" };
String[] ne = { "[ 13, 19]NamedEntity(PERS) (Markus)", "[ 31, 34]NamedEntity(ORG) (SAP)",
"[ 38, 46]NamedEntity(LUG) (Alemania)" };

AssertAnnotations.assertNamedEntity(ne, select(jcas, NamedEntity.class));
}
Expand Down
Loading
Loading