Conversation
|
Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
dukc
left a comment
There was a problem hiding this comment.
These two changes seem a bit unrelated to me, but they're small enough that I don't think demanding two separate PRs would be a good idea. And I think both of the changes are themselves correct.
In the grammar, I use
?to signify optional occurrence.Type: TypeCtors? BasicType TypeSuffixes? + TypeCtors? ref TypeCtors? BasicType TypeSuffixes + TypeCtors? LinkageAttribute ref? TypeCtors? BasicType TypeSuffixes BasicType: FundamentalType . QualifiedIdentifier QualifiedIdentifier Typeof Typeof . QualifiedIdentifier - TypeCtor ( Type ) + TypeCtor? ( Type ) Vector TraitsExpression MixinType TypeSuffixes: TypeSuffix TypeSuffixes? TypeSuffix: * [ ] [ AssignExpression ] [ AssignExpression .. AssignExpression ] [ Type ] delegate Parameters MemberFunctionAttributes? function Parameters FunctionAttributes?ParameterDeclaration: ParameterAttributes? BasicType Declarator + ParameterAttributes? LinkageAttribute ref? TypeCtors? BasicType Declarator ParameterAttributes? TypeIfCondition: IfConditionStorageClasses Identifier = Expression IfConditionStorageClasses? BasicType Declarator = Expression + IfConditionStorageClasses? LinkageAttribute ref? TypeCtors? BasicType Declarator = ExpressionForeachType: ForeachTypeAttributes? BasicType Declarator + ForeachTypeAttributes? LinkageAttribute ref? TypeCtors? BasicType Declarator ForeachTypeAttributes? Identifier ForeachTypeAttributes? alias Identifier