Fix #3081: ignore $ROOT_PACKAGE_DIR in source/import path warning#3102
Merged
thewilsonator merged 6 commits intodlang:masterfrom Mar 14, 2026
Merged
Fix #3081: ignore $ROOT_PACKAGE_DIR in source/import path warning#3102thewilsonator merged 6 commits intodlang:masterfrom
thewilsonator merged 6 commits intodlang:masterfrom
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5710288 bin/dub
-rough build time=68s
+rough build time=66sFull build output |
Contributor
Author
|
All Linux and Windows checks are passing. The macOS-13 checks were cancelled (likely CI infrastructure). Could a maintainer please review and re-run the macOS checks? |
Contributor
Author
|
Hi @thewilsonator, I've addressed your review comments — fixed the if (hasVar) indentation and restored proper indentation for auto pstr and foreach. Please take another look when you get a chance! |
Contributor
Author
|
Hi @thewilsonator, I've addressed all your review comments. All Linux and Windows checks are passing. The macOS-13 cancellations appear to be a CI infrastructure issue. Could you please take another look? |
thewilsonator
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3081 — DUB emits warnings for paths containing $ROOT_PACKAGE_DIR even though they are valid.
Changes: