fix: escape individual items when constructing environment variables#3103
Open
kmr-ankitt wants to merge 1 commit intodlang:masterfrom
Open
fix: escape individual items when constructing environment variables#3103kmr-ankitt wants to merge 1 commit intodlang:masterfrom
kmr-ankitt wants to merge 1 commit intodlang:masterfrom
Conversation
…t variables previously environment variables like IMPORT_PATHS, SOURCE_FILES, and LIBS were created by joining values directly. This could break when paths contained spaces. implement the existing TODO by escaping each item using escapeShellFileName before joining.
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5710288 bin/dub
rough build time=67sFull build output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr implements the TODO to escape individual items before joining them into environment variables.
Before
items were joined directly:
If a path contained spaces, e.g.
it could be interpreted as multiple shell arguments.
After
each item is escaped before joining, so paths and other values containing spaces are handled correctly.
this ensures paths and other values containing spaces are handled correctly.