ci: use docker github builder to build bin image and binaries#3520
ci: use docker github builder to build bin image and binaries#3520crazy-max merged 3 commits intodocker:masterfrom
Conversation
3aaccb8 to
e4c8478
Compare
.github/workflows/build.yml
Outdated
| meta-images: | | ||
| ${{ env.REPO_SLUG }} |
There was a problem hiding this comment.
Can't use env with reusable workflows 😞
https://github.com/docker/buildx/actions/runs/19329818722
Seems we need an extra job just to set it as an output: https://github.com/orgs/community/discussions/26671 😑
🙃 https://github.com/orgs/community/discussions/26671#discussioncomment-4295807
96dacaf to
acc33b1
Compare
|
GitHub hosted runner doesn't have enough space to build our image: https://github.com/docker/buildx/actions/runs/19330419315/job/55292703625#step:8:521 Hence why we free up disk space currently (see #3040) For our reusable workflow, one way to fix it would be to distribute build across runners: docker/github-builder#2 |
acc33b1 to
969b0cb
Compare
|
Switch reusable workflow ref to |
e491c64 to
fe39cf7
Compare
fe39cf7 to
a657c7e
Compare
|
Pushed extra commit to also build our binaries with our reusable workflow. |
9a64ed8 to
9d72d10
Compare
.github/workflows/build.yml
Outdated
| runner: amd64 | ||
| target: release | ||
| output: local | ||
| push: ${{ github.event_name != 'pull_request' }} |
There was a problem hiding this comment.
This one shouldn't be here right?
| push: ${{ github.event_name != 'pull_request' }} |
There was a problem hiding this comment.
Oh I see:
Something like sign-artifacts: ${{ github.event_name != 'pull_request' }} might be more intuitive, splitting push and manifest signing for local artifacts.
There was a problem hiding this comment.
Yes I'm working on refactoring the UX, I don't really like push as well, that's misleading. I will open an issue on github-builder repo to address this 🙏
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
be0f980 to
f62b285
Compare
f62b285 to
d633ff1
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
d633ff1 to
481e798
Compare
docker/github-builder#21
closes #3005
closes #3441