vendor: github.com/docker/cli v29.2.1 by thaJeztah · Pull Request #3617 · docker/buildx

thaJeztah · 2026-01-19T12:29:08Z

depends on vendor: update golang.org/x dependencies #3628

vendor: github.com/klauspost/compress v1.18.3

no changes in vendored code

fixes / downstream CVE-2025-61728

full diff: klauspost/compress@v1.18.2...v1.18.3

vendor: github.com/go-viper/mapstructure/v2 v2.5.0

full diff: go-viper/mapstructure@v2.4.0...v2.5.0

vendor: moby/api v1.53.0, moby/client v0.2.2

full diff:

api: moby/moby@api/v1.52.0...api/v1.53.0
client: moby/moby@client/v0.2.1...client/v0.2.2

vendor: github.com/docker/cli v29.2.0

full diff: docker/cli@v29.1.5...v29.2.0

vendor: github.com/docker/cli v29.2.1

full diff: docker/cli@v29.2.0...v29.2.1

thaJeztah · 2026-01-27T09:25:18Z

Interesting failure https://github.com/docker/buildx/actions/runs/21389923862/job/61574127472?pr=3617

=== Failed
=== FAIL: dap TestLaunch (unknown)
    client.go:96: [client] send: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false}}
    server.go:74: [server] recv: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false,"pathFormat":"path"}}
    server.go:200: [server] send: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:44: [client] recv: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:96: [client] send: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:74: [server] recv: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:200: [server] send: {"seq":2,"type":"event","event":"initialized"}
    client.go:44: [client] recv: {"seq":2,"type":"event","event":"initialized"}
    client.go:96: [client] send: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:200: [server] send: {"seq":3,"type":"response","request_seq":2,"success":true,"command":"launch"}
    server.go:74: [server] recv: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:200: [server] send: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    client.go:44: [client] recv: {"seq":3,"type":"response","request_seq":2,"success":true,"command":"launch"}
    client.go:44: [client] recv: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    server.go:200: [server] send: {"seq":5,"type":"event","event":"terminated","body":{}}
panic: sync: WaitGroup is reused before previous Wait has returned

goroutine 28 [running]:
sync.(*WaitGroup).Wait(0x140004cc048)
	/Users/runner/hostedtoolcache/go/1.25.6/arm64/src/sync/waitgroup.go:208 +0x14c
golang.org/x/sync/errgroup.(*Group).Wait(0x140004cc040)
	/Users/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:56 +0x28
github.com/docker/buildx/dap.(*Server).Serve.func4()
	/Users/runner/work/buildx/buildx/dap/server.go:61 +0x90
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/Users/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:93 +0x4c
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 24
	/Users/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:78 +0x90

DONE 829 tests, 1 skipped, 1 failure in 49.835s
Error: Process completed with exit code 1.

thaJeztah · 2026-01-27T10:21:05Z

Same test, different failure; https://github.com/docker/buildx/actions/runs/21392736648/job/61583385477?pr=3617

=== RUN   TestLaunch
    client.go:96: [client] send: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false}}
    server.go:74: [server] recv: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false,"pathFormat":"path"}}
    server.go:200: [server] send: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:44: [client] recv: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:96: [client] send: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:74: [server] recv: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:200: [server] send: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    server.go:200: [server] send: {"seq":3,"type":"event","event":"initialized"}
    client.go:44: [client] recv: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    adapter_test.go:61: 
        	Error Trace:	/vagrant/dap/adapter_test.go:61
        	            				/vagrant/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/usr/local/go/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive initialized event
        	Test:       	TestLaunch
    client.go:44: [client] recv: {"seq":3,"type":"event","event":"initialized"}
    client.go:96: [client] send: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:74: [server] recv: {"seq":3,"type":"request","command":"configurationDone"}
    server.go:200: [server] send: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    client.go:44: [client] recv: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"configurationDone"}
    server.go:74: [server] recv error: context deadline exceeded
    adapter_test.go:67: 
        	Error Trace:	/vagrant/dap/adapter_test.go:67
        	            				/vagrant/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/usr/local/go/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive configurationDone response
        	Test:       	TestLaunch
--- FAIL: TestLaunch (10.04s)

Also failing; https://github.com/docker/buildx/actions/runs/21392736648/job/61583385468?pr=3617

=== FAIL: dap TestSetBreakpoints (10.01s)
    client.go:96: [client] send: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false}}
    server.go:74: [server] recv: {"seq":1,"type":"request","command":"initialize","arguments":{"adapterID":"","linesStartAt1":false,"columnsStartAt1":false,"pathFormat":"path"}}
    server.go:200: [server] send: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:44: [client] recv: {"seq":1,"type":"response","request_seq":1,"success":true,"command":"initialize","body":{"supportsConfigurationDoneRequest":true}}
    client.go:96: [client] send: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:74: [server] recv: {"seq":2,"type":"request","command":"launch","arguments":null}
    server.go:200: [server] send: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    client.go:44: [client] recv: {"seq":2,"type":"response","request_seq":2,"success":true,"command":"launch"}
    adapter_test.go:122: 
        	Error Trace:	/home/runner/work/buildx/buildx/dap/adapter_test.go:122
        	            				/home/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive initialized event
        	Test:       	TestSetBreakpoints
    server.go:200: [server] send: {"seq":3,"type":"event","event":"initialized"}
    client.go:44: [client] recv: {"seq":3,"type":"event","event":"initialized"}
    client.go:96: [client] send: {"seq":3,"type":"request","command":"setBreakpoints","arguments":{"source":{"name":"Dockerfile","path":"/home/runner/work/_temp/TestSetBreakpoints2501232425/001/Dockerfile"}}}
    server.go:74: [server] recv: {"seq":3,"type":"request","command":"setBreakpoints","arguments":{"source":{"name":"Dockerfile","path":"/home/runner/work/_temp/TestSetBreakpoints2501232425/001/Dockerfile"}}}
    server.go:200: [server] send: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"setBreakpoints","body":{"breakpoints":[]}}
    client.go:44: [client] recv: {"seq":4,"type":"response","request_seq":3,"success":true,"command":"setBreakpoints","body":{"breakpoints":[]}}
    server.go:74: [server] recv error: context deadline exceeded
    adapter_test.go:131: 
        	Error Trace:	/home/runner/work/buildx/buildx/dap/adapter_test.go:131
        	            				/home/runner/work/buildx/buildx/vendor/golang.org/x/sync/errgroup/errgroup.go:93
        	            				/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/asm_amd64.s:1693
        	Error:      	did not receive setBreakpoints response
        	Test:       	TestSetBreakpoints

DONE 831 tests, 1 skipped, 1 failure in 59.764s
Error: Process completed with exit code 1.

no changes in vendored code - fixes / downstream CVE-2025-61728 full diff: klauspost/compress@v1.18.2...v1.18.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

full diff: go-viper/mapstructure@v2.4.0...v2.5.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

full diff: - api: moby/moby@api/v1.52.0...api/v1.53.0 - client: moby/moby@client/v0.2.1...client/v0.2.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

full diff: docker/cli@v29.1.5...v29.2.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

full diff: docker/cli@v29.2.0...v29.2.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

github-actions bot assigned thaJeztah Jan 19, 2026

github-actions bot added the area/dependencies label Jan 19, 2026

thaJeztah force-pushed the bump_modules branch 2 times, most recently from bc4d37c to 78293e6 Compare January 27, 2026 08:26

thaJeztah mentioned this pull request Jan 27, 2026

vendor: update golang.org/x dependencies #3628

Merged

thaJeztah changed the title ~~vendor: github.com/docker/cli v29.2.0-rc.2~~ vendor: github.com/docker/cli v29.2.0 Jan 27, 2026

thaJeztah force-pushed the bump_modules branch from 78293e6 to d38e665 Compare January 27, 2026 10:00

crazy-max mentioned this pull request Jan 27, 2026

Flaky test: TestSetBreakpoints #3598

Open

thaJeztah changed the title ~~vendor: github.com/docker/cli v29.2.0~~ vendor: github.com/docker/cli v29.2.1 Feb 2, 2026

thaJeztah added 5 commits February 4, 2026 11:03

vendor: github.com/klauspost/compress v1.18.3

eaf81b6

no changes in vendored code - fixes / downstream CVE-2025-61728 full diff: klauspost/compress@v1.18.2...v1.18.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

vendor: github.com/go-viper/mapstructure/v2 v2.5.0

6b71de0

full diff: go-viper/mapstructure@v2.4.0...v2.5.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

vendor: moby/api v1.53.0, moby/client v0.2.2

9aa7e15

full diff: - api: moby/moby@api/v1.52.0...api/v1.53.0 - client: moby/moby@client/v0.2.1...client/v0.2.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

vendor: github.com/docker/cli v29.2.0

8bd5bd4

full diff: docker/cli@v29.1.5...v29.2.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

vendor: github.com/docker/cli v29.2.1

79b14ea

full diff: docker/cli@v29.2.0...v29.2.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the bump_modules branch from 380ea10 to 79b14ea Compare February 4, 2026 10:04

thaJeztah marked this pull request as ready for review February 4, 2026 11:21

thaJeztah requested a review from crazy-max February 4, 2026 11:21

crazy-max approved these changes Feb 4, 2026

View reviewed changes

crazy-max merged commit 67915f9 into docker:master Feb 4, 2026
159 checks passed

thaJeztah deleted the bump_modules branch February 4, 2026 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vendor: github.com/docker/cli v29.2.1#3617

vendor: github.com/docker/cli v29.2.1#3617
crazy-max merged 5 commits intodocker:masterfrom
thaJeztah:bump_modules

thaJeztah commented Jan 19, 2026 •

edited

Loading

Uh oh!

thaJeztah commented Jan 27, 2026

Uh oh!

thaJeztah commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thaJeztah commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

vendor: github.com/klauspost/compress v1.18.3

vendor: github.com/go-viper/mapstructure/v2 v2.5.0

vendor: moby/api v1.53.0, moby/client v0.2.2

vendor: github.com/docker/cli v29.2.0

vendor: github.com/docker/cli v29.2.1

Uh oh!

thaJeztah commented Jan 27, 2026

Uh oh!

thaJeztah commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thaJeztah commented Jan 19, 2026 •

edited

Loading