dap: improve file explorer source names#3631
Merged
tonistiigi merged 1 commit intodocker:masterfrom Feb 4, 2026
Merged
Conversation
Improves the naming for file explorer names when the input relates directly to a source. This is most common when the input is the context (which is just usually a simple source like `local://context`). This should help in most circumstances in determining which input is which. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
tonistiigi
reviewed
Feb 4, 2026
| // an exec operation. | ||
| if exec, ok := op.Op.(*pb.Op_Exec); ok { | ||
| for _, m := range exec.Exec.Mounts { | ||
| if m.Input >= 0 && m.Input == int64(index) { |
Member
There was a problem hiding this comment.
Does this assume that root mount is always input 0? I don't think there is a guarantee for that. Better to check .Dest == "/"
tonistiigi
approved these changes
Feb 4, 2026
| // an exec operation. | ||
| if exec, ok := op.Op.(*pb.Op_Exec); ok { | ||
| for _, m := range exec.Exec.Mounts { | ||
| if m.Input >= 0 && m.Input == int64(index) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the naming for file explorer names when the input relates
directly to a source. This is most common when the input is the context
(which is just usually a simple source like
local://context).This should help in most circumstances in determining which input is
which.
Fixes #3368.