commands: adds metrics associated with the debugger#3633
Merged
tonistiigi merged 1 commit intodocker:masterfrom Jan 28, 2026
Merged
commands: adds metrics associated with the debugger#3633tonistiigi merged 1 commit intodocker:masterfrom
tonistiigi merged 1 commit intodocker:masterfrom
Conversation
Add metrics associated with the debugger that are reported through the metrics writer. This adds a few attributes that are only added when a debugger is used with either the `debug` command or `dap` command. At the moment, these metrics show up the exact same as a build and we can't identify if something is using `dap` or `debug` since they use the same code path. This also adds a new available metric that can be utilized by plugins to report additional information. The metrics will check if an environment variable `BUILDX_DAP_USER_AGENT` is sent and that will get included in the metrics if they are enabled. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
requested review from
chelnak,
crazy-max and
tonistiigi
and removed request for
chelnak
Collaborator
Author
|
@chelnak sorry I was trying to type in @crazy-max and auto complete put your name first when I was pressing enter. |
This was referenced Jan 28, 2026
tonistiigi
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add metrics associated with the debugger that are reported through the
metrics writer. This adds a few attributes that are only added when a
debugger is used with either the
debugcommand ordapcommand.At the moment, these metrics show up the exact same as a build and we
can't identify if something is using
dapordebugsince they use thesame code path.
This also adds a new available metric that can be utilized by plugins to
report additional information. The metrics will check if an environment
variable
BUILDX_DAP_USER_AGENTis sent and that will get included inthe metrics if they are enabled.