Open
Conversation
crazy-max
force-pushed
the
imagetools-create-digest
branch
from
e6927ef to
6c3c4c7
Compare
Member
|
Oh! Tests are failing though, and could be related? |
crazy-max
force-pushed
the
imagetools-create-digest
branch
from
6c3c4c7 to
f5568d2
Compare
thaJeztah
reviewed
Feb 3, 2026
tests/imagetools.go
Outdated
Comment on lines
101
to
103
| t.Logf("digest: %s", outputDigest) | ||
| _, err = digest.Parse(outputDigest) | ||
| require.NoError(t, err) |
Member
There was a problem hiding this comment.
Was the t.Logf for debugging? (I always try to avoid logs in tests, and instead only log on failure; e.g.;
Suggested change
| t.Logf("digest: %s", outputDigest) | |
| _, err = digest.Parse(outputDigest) | |
| require.NoError(t, err) | |
| _, err = digest.Parse(outputDigest) | |
| require.NoError(t, err, "digest: %s", outputDigest) |
Member
|
I think I prefer |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
imagetools-create-digest
branch
from
f5568d2 to
1db71a1
Compare
crazy-max
changed the title
Member
Author
Should be good now |
tonistiigi
reviewed
Feb 5, 2026
|
|
||
| if err == nil && len(in.metadataFile) > 0 { | ||
| if err := writeMetadataFile(in.metadataFile, map[string]any{ | ||
| exptypes.ExporterImageDigestKey: desc.Digest.String(), |
Member
There was a problem hiding this comment.
Maybe already better to just add ExporterImageDescriptorKey ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Docker GitHub Builder workflows we are merging manifests with the
imagetools createcommand. This command doesn't output the pushed digest whilebuildorbakecommands do it.This PR add a
metadata-fileflag similar tobuildandbakecommands.This will be necessary in our github builder so we can have an output for this digest that can then be used in subsequent jobs.