cli/registry/client: remove dependency on trust / notary#5880
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 3, 2025
Merged
cli/registry/client: remove dependency on trust / notary#5880thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
The client was only using the Actions consts, but the trust package also has a dependency on notary. Remove the import to prevent Notary becoming a dependency for uses of the cli code. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Looks like I forgot to include this one in #5878 - this one should also be trivial; the predefined vars are nice, but don't add much value, and we shouldn't depend on the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5880 +/- ##
=======================================
Coverage 59.31% 59.31%
=======================================
Files 353 353
Lines 29735 29735
=======================================
Hits 17637 17637
Misses 11117 11117
Partials 981 981 |
Benehiko
approved these changes
Mar 3, 2025
vvoland
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client was only using the Actions consts, but the trust package also has a dependency on notary. Remove the import to prevent Notary becoming a dependency for uses of the cli code.
- A picture of a cute animal (not mandatory but encouraged)