cli/command/formatter: add missing go:build tag#5919
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 10, 2025
Merged
Conversation
Member
Author
|
Ah. Derp. Linter doesn't agree; Ok; build-tags it is then |
Seen failing when used elsewhere;
vendor/github.com/docker/cli/cli/command/formatter/displayutils.go:78:20: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
robmry
approved these changes
Mar 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5919 +/- ##
=======================================
Coverage 59.27% 59.27%
=======================================
Files 358 358
Lines 29772 29772
=======================================
Hits 17648 17648
Misses 11152 11152
Partials 972 972 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternatively, we could add another build-tag, but this probably is less impactful.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)