vendor.mod: update minimum go version to go1.23

[thaJeztah]

• subset of update minimum go version to go1.23 #5868
• relates to vendor: golang.org/x/crypto v0.35.0 #5869
• relates to update minimum go version to go1.23 moby/moby#49541

Go maintainers started to unconditionally update the minimum go version for golang.org/x/ dependencies to go1.23, which means that we'll no longer be able to support any version below that when updating those dependencies;

all: upgrade go directive to at least 1.23.0 [generated]

By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
per the Go Release Policy (https://go.dev/doc/devel/release#policy).

For golang/go#69095.

This updates our minimum version to go1.23, as we won't be able to maintain compatibility with older versions because of the above.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.32%. Comparing base (3d3f780) to head (a9e6180).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5920   +/-   ##
=======================================
  Coverage   59.32%   59.32%           
=======================================
  Files         358      358           
  Lines       29783    29783           
=======================================
  Hits        17669    17669           
  Misses      11145    11145           
  Partials      969      969           

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[thaJeztah]

Thanks!

[tianon]

It's ironic that this broke my builds, because while I upgraded Go, the Go compatibility promise famously doesn't apply to the way you hold the toolchain, so 1.23 requires I hold it slightly differently (I've fixed it now, but man, I want off the merry-Go-round 😭 ❤️).

[thaJeztah]

Wait, what broke?

Is it because "go1.23 downgrading itself to pretend it's go1.22" is different than "go1.23 running as go1.23"? That feature still baffles me TBH

[thaJeztah]

(downgrading itself, as in: internally downgrading features, not the "let's download a different toolchain" variant)

[tianon]

On Go 1.22, rm vendor/modules.txt + grep -E '^(module|go) ' vendor.mod > go.mod + GOFLAGS='-mod=vendor' was enough to successfully use vendor/ during build (even in module mode), and now I have to also include -modfile=vendor.mod or it complains that the vendored modules exist but aren't explicitly referenced consistently between the modfile and vendor/modules.txt (whether I delete it or not, it refuses to use deps from vendor/ unless they're explicitly referenced in both places). 🙃

(I never thought I'd miss the simplicity of GOPATH, but here we are!)

[thaJeztah]

I want off the merry-Go-round 😭 ❤️

May I recommend TypeScript? They say it's nice

[thaJeztah]

I want off the merry-Go-round 😭 ❤️

May I recommend TypeScript? They say it's nice

Well... that comment didn't age well;

• https://github.com/microsoft/typescript-go

[tianon]

Real big "But Doctor, I Am Pagliacci" vibes coming off that suggestion 😂

I wonder if that'll give https://github.com/MichiganTypeScript/typescript-types-only-wasm-runtime a better framerate in Doom, though. 🤔

[thaJeztah]

and now I have to also include -modfile=vendor.mod

Also .. sigh,,, !

Hopefully this repo can move to a go.mod soon. In the meantime; any changes we should make in our scripts? (I haven't immediately seen issues locally with my "symlink go.(mod|sum) to vendor.(mod|sum)" hack, but maybe I didn't look closely 🙈

[tianon]

Honestly with #5896, it's pretty close to a 100% stock go build being totally sufficient, and IMO that ought to be the goal (rephrased, that's "improve the scripts by deleting them").