Revert "cli/command: remove uses of GetAuthConfigKey, ParseRepositoryInfo"#5964
Merged
thaJeztah merged 1 commit intodocker:masterfrom Mar 25, 2025
Merged
Revert "cli/command: remove uses of GetAuthConfigKey, ParseRepositoryInfo"#5964thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
…Info" This reverts commit 79141ce. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
added
status/2-code-review
kind/bugfix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5964 +/- ##
==========================================
+ Coverage 59.08% 59.09% +0.01%
==========================================
Files 354 354
Lines 29739 29733 -6
==========================================
Hits 17572 17572
+ Misses 11197 11191 -6
Partials 970 970 🚀 New features to boost your workflow:
|
thaJeztah
approved these changes
Mar 25, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
trying to spot where the bug is, but there's so many levels of complexity in this code, so don't see it at a glance 😞
This was referenced Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 79141ce.
Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com