Open
Conversation
mdelapenya
reviewed
Jul 23, 2025
ndeloof
force-pushed
the
build_remote
branch
2 times, most recently
from
ba9dc77 to
95d50f2
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
mdelapenya
reviewed
Jul 24, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM! Could you add a test fetching a GH repo, i.e. https://github.com/testcontainers/helloworld? WDYT?
If fetching a repo could lead to flakiness at test time, how could we emulate the clone process?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for building image from a git remote context
TBD: this introduces a dependency on github.com/docker/docker/builder/remotecontext, need to check this is aligned with moby/moby#50280 trying to isolate a "moby API client" module from implementation details
Also left remote HTTP build context support for a follow-up PR