test: blind_bbs_plus_sig_and_message_equality#29
Conversation
Signed-off-by: Harold Carr <harold.carr@oracle.com>
| // This test was motivated by the fact that the existing blinding tests | ||
| // proof_system/tests/bbs_plus_and_accumulators.rs | ||
| // requesting_partially_blind_bbs_plus_sig | ||
| // requesting_partially_blind_bbs_plus_sig |
There was a problem hiding this comment.
This is duplicate of the above line.
| // requesting_partially_blind_bbs_plus_sig | ||
| // requesting_partially_blind_bbs_plus_sig | ||
| // requesting_partially_blind_bbs_sig | ||
| // do not use the unblinded/blind signature in proofs. Hence, this test. |
There was a problem hiding this comment.
I didn't use the "unblinded" sig in proof (of knowledge of sig) as other tests do that and an "unblinded" sig is same as a regular sig
There was a problem hiding this comment.
The requesting_partially_blind_bbs_sig test doesn't unblind the blinded signature.
The requesting_partially_blind_bbs_plus_sig test does, and then verifies the unblinded signature, but does not create any proofs with it. One might argue that verifying the unblinded signature is sufficient to ensure it's "just the same as a regular sig", and therefore can be used to create all the same proofs. However, I think that it's worthwhile explicitly testing that we can use the unblinded signature to create and verify at least one proof.
There was a problem hiding this comment.
requesting_partially_blind_bbs_sig doesn't have the blinding term (s) and thus no unblind function for BBS sigs. The user might separately add blinding to achieve the same effect as BBS+
| // do not use the unblinded/blind signature in proofs. Hence, this test. | ||
|
|
||
| blind_bbs_plus_sig_and_message_equality_aux(true).unwrap(); | ||
| if blind_bbs_plus_sig_and_message_equality_aux(false).is_ok() { |
There was a problem hiding this comment.
Any reason you wouldn't want assert!(blind_bbs_plus_sig_and_message_equality_aux(false).is_err()) to replace this if block.
There was a problem hiding this comment.
No reason 😄. Fixed, thanks.
|
Thanks for the PR @mark-moir . |
Signed-off-by: Mark Moir <mark.moir@oracle.com>
Signed-off-by: Mark Moir <mark.moir@oracle.com>
|
Thanks for the updates. |
3 participants
This PR adds several tests. Each test:
We test that
This test was motivated by the fact that the existing blinding tests in
proof_system/tests/bbs_plus_and_accumulators.rs:requesting_partially_blind_bbs_plus_sigrequesting_partially_blind_bbs_plus_sigrequesting_partially_blind_bbs_sigdo not use unblinded/blind signatures in proofs.
This PR also adds a
NOTICE.mdfile saying that Oracle contributed. We are required to include such notice for our approval to contribute to the repo. By putting a notice in one place, we avoid putting it in individual files that we contribute to, which in future may include existing files. Hope this is OK.