Fix: fix collapse selector#2113
Closed
Embers-of-the-Fire wants to merge 0 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
Eee, I don't know why the ci failed, as I've tested it locally and there's no error. |
Member
|
Hello, thanks!
It didn't fail, I had to hit approve to make ci run. |
trusktr
approved these changes
Jul 3, 2023
Member
|
Hi @Embers-of-the-Fire ,sorry for the delay, could you plz solve the conflict and I will do the merge asap. |
feddd69 to
a2de128
Compare
Author
|
@Koooooo-7 It has been such long time that the structure of docsify has already changed a lot :(. The bug and the code are all re-written. It seems that the bug is fixed by someone else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The initial selector uses
element.nextSibling, which may select an empty#texton Chromium-based browsers.Here is an instance:
For a link in the sidebar, it usually seems like this:
The collapsing function uses
element.nextSiblingto check if collapsing is needed. However, in Chromium-based browsers, a blank text tag will possibly be inserted, making the directory unable to collapse.What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change? (check one)
Tested in the following browsers: