added support for RemoveVertex, UpdateEdge, and EdgeCount#3
Open
jonbrandenburg wants to merge 1 commit intodominikbraun:mainfrom
Open
added support for RemoveVertex, UpdateEdge, and EdgeCount#3jonbrandenburg wants to merge 1 commit intodominikbraun:mainfrom
jonbrandenburg wants to merge 1 commit intodominikbraun:mainfrom
Conversation
|
This looks ok to me @dominikbraun is it worth merging in? |
Owner
|
@ngfgrant Absolutely, I haven't had the time yet but I'm going to merge @jonbrandenburg's PRs in this and the main repo soon. |
|
Nice one - let me know if I can help in any way 👍 |
|
Update on this? I also bumped into the same issue. quick hack on your go.mod, use jonbrandenburg patched version: I'll leave here a snippet of code that won't compile yet. When this gets merged it will be easy to check: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to update the library to support the latest changes / graph.Store interface. I recognize this PR might be more palatable if it were broken down into smaller chunks and/or reworked however I thought I'd post it now to get some feedback before doing any more work on it.