Skip to content

fix(dired): prevent dirvish from killing root buffers on quit #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kovan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(dired): prevent dirvish from killing root buffers on quit #8663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions modules/emacs/dired/config.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,10 @@ Fixes #3939: unsortable dired entries on Windows."
(set-popup-rule! "^ ?\\*\\(?:[Dd]irvish\\|SIDE :: \\).*" :ignore t)

;; Fixes #8038. This setting is for folks who expect to be able to switch back
;; to dired buffers where the file is opened from. In other cases, don't
;; recycle sessions. We don't want leftover buffers lying around, especially
;; if users are reconfiguring Dirvish or trying to recover from an error. It's
;; too easy to accidentally break Dirvish (e.g. by focusing the header window)
;; at the moment. Starting from scratch isn't even that expensive, anyway.
(setq dirvish-reuse-session 'open)
;; to dired buffers where the file is opened from. Doom's cleanup hook
;; (`+dired--cleanup-dirvish-h') handles killing sessions on project/workspace
;; switches, so `t' is safe here.
(setq dirvish-reuse-session t)

(if (modulep! +dirvish)
(setq dirvish-attributes '(file-size)
Expand Down