Skip to content

theme: add kanagawa#790

Open
Anskrevy wants to merge 20 commits into
doomemacs:masterfrom
Anskrevy:master
Open

theme: add kanagawa#790
Anskrevy wants to merge 20 commits into
doomemacs:masterfrom
Anskrevy:master

Conversation

@Anskrevy

@Anskrevy Anskrevy commented Jun 6, 2023

Copy link
Copy Markdown

This theme is based on rebelot's theme by the same name. I've never written a theme before and still pretty new to using emacs so please let me know if I've missed something/something doesn't look right.

Fixes #0000
References #0000
Replaces #0000


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

Screenshots

pic-window-230605-1804-21
pic-window-230605-1807-22

@gagbo gagbo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Still not sure when it's going to get merged, but there are a few things you can change meanwhile to help the PR :)

Comment thread README.md Outdated
Comment thread themes/doom-kanagawa-theme.el Outdated
@hlissner hlissner added the themes Requests that a theme be added or removed label Sep 6, 2023
@hlissner hlissner added this to the v2.4.0 milestone Dec 2, 2023
@azzamsa

azzamsa commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

Is anything else needed for this PR to merge into the master? I am here to help.

@hlissner hlissner changed the title theme: add kanagawa theme theme: add kanagawa Jan 10, 2025
Comment thread themes/doom-kanagawa-theme.el Outdated
Co-authored-by: Prashant Vithani <prashantvithani@gmail.com>
@NU11V01D

Copy link
Copy Markdown

Anything left for the theme to be merged?

@Anskrevy

Copy link
Copy Markdown
Author

Since I opened this pull request, reblot has released an official kanagawa wave theme for Emacs. I've been working on porting the three main themes but they are rather different from the one in this PR, which is a hybrid of the wave and dragon themes. Here are some screenshots of the new themes.

wave

image

dragon

image

lotus

image

abyss (the hybrid)

image

Since this has not been merged, would it be best to include these themes in this PR, or open a new PR for the three original themes and rebrand this one?

@NU11V01D

Copy link
Copy Markdown

I'd include rebelot's here and name differently the custom variations. Wave, Lotus and Dragon would be the originals and the other variations would be up to you.

@Anskrevy

Anskrevy commented Oct 1, 2025

Copy link
Copy Markdown
Author

Sounds good. All the necessary changes have been made. Let me know if there are any issues.

@NU11V01D

Copy link
Copy Markdown

@gagbo, what's missing for the PR to be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

themes Requests that a theme be added or removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants